Skip to content

Use flex for radio layout#11254

Closed
joedolson wants to merge 4 commits intoWordPress:trunkfrom
joedolson:64816-flex
Closed

Use flex for radio layout#11254
joedolson wants to merge 4 commits intoWordPress:trunkfrom
joedolson:64816-flex

Conversation

@joedolson
Copy link
Copy Markdown
Contributor

This PR extends the patch by @siliconforks to remove some additional CSS.

The class .tog is used only on the adim theme color switching and in the selector to set the front page between a page or a post. Removing these styles appears to have no impact. The line-height also appears to now be irrelevant.

Some additional cross-browser testing would probably be beneficial.

Trac ticket: https://core.trac.wordpress.org/ticket/64816

Use of AI Tools

None


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 14, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joedolson, sabernhardt, siliconforks, shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@siliconforks
Copy link
Copy Markdown

The class .tog is used only on the adim theme color switching and in the selector to set the front page between a page or a post.

Should tog be removed from the HTML code too?

That class is extremely ancient and it doesn't currently seem to serve any purpose (if it ever did).

https://core.trac.wordpress.org/changeset/3581

@joedolson
Copy link
Copy Markdown
Contributor Author

I checked CSS, but i didn't check whether it was used in JS anywhere. It might be possible to remove; that will need a bit more checking. It's definitely very old!

joedolson and others added 3 commits March 17, 2026 09:51
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
@joedolson joedolson requested a review from sabernhardt March 17, 2026 16:09
@joedolson
Copy link
Copy Markdown
Contributor Author

I removed the .tog classes from their inputs; I couldn't find any representation in JS, and removing them did not impact functionality.

@shail-mehta
Copy link
Copy Markdown
Member

The radio buttons are now centered when the display scale is set to 125%.✅

Before After
before-patch after-patch

@github-actions
Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62089
GitHub commit: 96f335d

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants